Move RE files to under "export" #96
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=====================================
Coverage 0.80% 0.80%
=====================================
Files 25 25
Lines 1617 1617
=====================================
Hits 13 13
Misses 1604 1604 ☔ View full report in Codecov by Sentry. |
MonikaFu
approved these changes
Oct 30, 2024
Collaborator
MonikaFu
left a comment
MonikaFu
left a comment
There was a problem hiding this comment.
LGTM! Should we also adjust user results generation accordingly?
Collaborator
Author
|
No adjustment needed. This is just changing the step where we copy the PDFs from inputs to outputs as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the CTM platform, it appears that only the
exportsubdirectory of the report outputs directory is exposed tot he user. This PR places the RE PDF files inreport/exportrather thanreport/real_estateTest Results: https://beta.transitionmonitor.com/pacta/share/bc86ff7a-5ed4-4acb-9814-3cf06080d5df